replace deprecated snmpm:sync_get/4 by snmpm:sync_get2/4
#416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:sync_get2/4` Link: https://www.erlang.org/docs/24/general_info/scheduled_for_removal#otp-25 Signed-off-by: Ariel Otilibili <[email protected]>
|
I am not sure if those changes are sufficient, gen_statem requires for example callback_mode() hook that i think is missing, and i think it also adds extra argument to state callback functions it calls, so i am not sure if this will be working as expected. |
ariel-anieli
force-pushed
the
remove-deprecations
branch
from
6f66863 to
3ce0dac
Compare
ariel-anieli
changed the title
gen_fsm & snmpm:sync_get/4snmpm:sync_get/4 by snmpm:sync_get2/4
Thanks for the feedback, @prefiks; I reduced the scope of the PR to |
|
Hello; any news on the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snmpm:sync_get/4is schedulled for removal in OTP 25.