Skip to content

Conversation

@pawelpaszki
Copy link
Contributor

Issue link

https://issues.redhat.com/browse/RHOAIENG-34272

What changes have been made

Building codeflare-sdk e2e tests image compatible with shift-left structure on RHOAI

Verification steps

An env file with IDP credentials is required (this will be provided in the rhoai-test-flow pipeline from vault (to be added)). The file has to have the following content:

OCP_ADMIN_USER_USERNAME=htpasswd-cluster-admin-user
OCP_ADMIN_USER_PASSWORD=<password for ^^ user as set up by rhoai-test-flow>
TEST_USER_USERNAME=ldap-admin1
TEST_USER_PASSWORD=<password for ^^ user as set up by rhoai-test-flow>

The test tags provided match current setup in the ods-ci, so each of them needs to be tested by replacing below with the following values:

tier1
smoke
pre_upgrade
post_upgrade

A cluster with RHOAI 3.0 installed (along with RHBoK operator) and the usual IDP setup are mandatory to run the verification steps:

podman build --arch=amd64 -f images/tests/Dockerfile -t quay.io/opendatahub/codeflare-sdk-tests:latest .
mkdir results # in the root of the repo - this will be passed as a volume to the container
oc login # to the cluster ^^ with http admin
# containerEnvFile created - see its content above
podman run --rm -it --pull "never" \
  --platform linux/amd64 \
  -v ~/.kube/config:/codeflare-sdk/tests/.kube/config:ro \
  -v ./results:/codeflare-sdk/tests/results:Z --env-file <path to containerEnvFile with correct content> \
  quay.io/opendatahub/codeflare-sdk-tests:latest -m <tag>

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 20, 2025

@pawelpaszki: This pull request references RHOAIENG-34272 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Issue link

https://issues.redhat.com/browse/RHOAIENG-34272

What changes have been made

Building codeflare-sdk e2e tests image compatible with shift-left structure on RHOAI

Verification steps

An env file with IDP credentials is required (this will be provided in the rhoai-test-flow pipeline from vault (to be added)). The file has to have the following content:

OCP_ADMIN_USER_USERNAME=htpasswd-cluster-admin-user
OCP_ADMIN_USER_PASSWORD=<password for ^^ user as set up by rhoai-test-flow>
TEST_USER_USERNAME=ldap-admin1
TEST_USER_PASSWORD=<password for ^^ user as set up by rhoai-test-flow>

The test tags provided match current setup in the ods-ci, so each of them needs to be tested by replacing below with the following values:

tier1
smoke
pre_upgrade
post_upgrade

A cluster with RHOAI 3.0 installed (along with RHBoK operator) and the usual IDP setup are mandatory to run the verification steps:

podman build --arch=amd64 -f images/tests/Dockerfile -t quay.io/opendatahub/codeflare-sdk-tests:latest .
mkdir results # in the root of the repo - this will be passed as a volume to the container
oc login # to the cluster ^^ with http admin
# containerEnvFile created - see its content above
podman run --rm -it --pull "never" \
 --platform linux/amd64 \
 -v ~/.kube/config:/codeflare-sdk/tests/.kube/config:ro \
 -v ./results:/codeflare-sdk/tests/results:Z --env-file <path to containerEnvFile with correct content> \
 quay.io/opendatahub/codeflare-sdk-tests:latest -m <tag>

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.13%. Comparing base (f336a2d) to head (e86d6ac).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #939   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files          24       24           
  Lines        2096     2096           
=======================================
  Hits         1973     1973           
  Misses        123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
@pawelpaszki pawelpaszki merged commit dcd430a into project-codeflare:main Nov 20, 2025
18 of 21 checks passed
@pawelpaszki pawelpaszki deleted the RHOAIENG-34272 branch November 20, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants