Un-pend a test for catalog URLs with slashes in the document ID #3595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref #911 Solr documents with a slash in the ID seem to route correctly without additional changes now. I tested by adding a document to the index and then checking its catalog URL; Rails's link_to seems to automatically generate a link with an encoded slash. Unfortunately this does not apply to a period, so full URLs won't work.
thatbudakguy
force-pushed
the
slash-routing
branch
from
5cd5deb to
6a2bd04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #911
Solr documents with a slash in the ID seem to route correctly
without additional changes now. I tested by adding a document to
the index and then checking its catalog URL; Rails's link_to
seems to automatically generate a link with an encoded slash.
Unfortunately this does not apply to a period, so full URLs won't
work.