Allow passing counter metric name to datapoint to show in case of validation error#1121
Allow passing counter metric name to datapoint to show in case of validation error#1121AntuanRokanten wants to merge 1 commit intoprometheus:mainfrom
Conversation
| package io.prometheus.metrics.model.snapshots; | ||
|
|
||
| public abstract class DataPointSnapshot { | ||
| private final String metricName; |
There was a problem hiding this comment.
let's add https://mvnrepository.com/artifact/com.google.code.findbugs/jsr305/3.0.2 (complile only) and annotate with @Nullable
| this(null, value, labels, exemplar, createdTimestampMillis, scrapeTimestampMillis); | ||
| } | ||
|
|
||
| public CounterDataPointSnapshot( |
There was a problem hiding this comment.
not sure what you mean here, please elaborate
There was a problem hiding this comment.
I think we don't need an overloaded ctor - you can just use the builder to pass the metric name
| return this; | ||
| } | ||
|
|
||
| public Builder metricName(String metricName) { |
|
started to refactor in main...pass-metric-name-to-datapoint |
hey hi @zeitlinger , is there any progress about this PR? |
no - I lost track of it. Feel free to give it a go 😄 |
|
This PR has been marked as stale due to 120 days of inactivity. It will be automatically closed if there is no further activity over the next 30 days. |
3 participants
@zeitlinger
WRT #1090