-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Add Lighthouse recommendations and caching #8207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Please add an entry to the corresponding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please @Chan9390 , can you add the CHANGELOG.md
and resolve the conflicts with master
Context
Lighthouse provides a chat interface to interact with findings. This PR provides recommendations and insights for cloud security findings of most recent scans.
Description
This PR adds the following:
With this PR, NextJS directly integrates with Valkey. It stores data with tenant key in it. All valkey keys have the following format:
_lighthouse:<TENANTUUID>:<KEYNAME>
(ex:_lighthouse:70bd85f3-6446-4bb5-bd68-ad52264fcc87:processed_scan_ids
)Different keys and their purpose:
processed_scan_ids
- Most recent scans IDs that were processedscan-summary
- Contains scan summary of scans completed in last 24 hours. It highlights newly detected issues in the last scans ordered by severity. It also list top 10 issues based on severity.recommendations
- Short title that will be displayed in bannercached-messages:recommendation
- The long description & explanation showed when user clicks on bannercached-messages:question_1
- Answer to suggested question 1cached-messages:question_2
- Answer to suggested question 2cached-messages:question_3
- Answer to suggested question 3cached-messages:question_4
- Answer to suggested question 4How to test
Create a new instance of Prowler (without Lighthouse configuration). You should find a banner as follows:
Without adding any providers, configure valid lighthouse keys. The dashboard shouldn't have any banner (as there's no completed scan in last 24 hours)
Add a provider and then initiate a scan. The dashboard would have the following banner:
Once the processing is done, you would have a banner with recommendation from your environment (the recommendation would differ based on your findings):
When you click on the banner, it will take you to a chat interface with detailed information about the recommendation:
You can then continue interacting with the recommendation:
Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.