Skip to content

Add experimental "no-panic" feature. #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add experimental "no-panic" feature. #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
362525f
Add experimental "no-panic" feature.
PiotrSikora Jun 5, 2025
28c4618
Merge branch 'main' into no-panic
PiotrSikora Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,20 @@ rust_library(
],
)

rust_library(
name = "proxy_wasm_no_panic",
srcs = glob(["src/*.rs"]),
crate_features = ["no-panic"],
crate_name = "proxy_wasm",
edition = "2018",
visibility = ["//visibility:public"],
deps = [
":proxy_wasm_build_script",
"//bazel/cargo/remote:hashbrown",
"//bazel/cargo/remote:log",
],
)

rust_binary(
name = "http_auth_random",
srcs = ["examples/http_auth_random/src/lib.rs"],
Expand Down
4 changes: 4 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ build = "build.rs"
hashbrown = "0.15"
log = "0.4"

[features]
default = []
no-panic = []
Copy link
Member Author

@PiotrSikora PiotrSikora Jun 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This will depend on the strict-header-value (#287) once that PR is merged in order to eliminate UTF-8 panics in HTTP field values (as of now, that PR doesn't change the type of field names, but all valid HTTP field name characters are also valid UTF-8 characters).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexsnaps does this sound reasonable to you?


[profile.release]
lto = true
opt-level = 3
Expand Down
2 changes: 1 addition & 1 deletion examples/http_auth_random/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ crate-type = ["cdylib"]

[dependencies]
log = "0.4"
proxy-wasm = { path = "../../" }
proxy-wasm = { path = "../../", features = ["no-panic"] }

[profile.release]
lto = true
Expand Down
Loading
Loading