159 alt text sidekiq job #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than serializing the entire, just passes the path to the Job. This is enough for the Job to send to the AltText client.
Upon refresh; live updates will be implemented in #161.
ajkiessl
requested changes
Oct 20, 2025
app/jobs/image_alt_text_job.rb
Outdated
Comment on lines
13
to
23
| timer = 0 | ||
| until alt_text = client.process_image(tmp_path, prompt: File.read('prompt.txt'), | ||
| model_id: ENV.fetch('LLM_MODEL', nil)) | ||
| sleep OUTPUT_POLLING_INTERVAL | ||
| timer += OUTPUT_POLLING_INTERVAL | ||
| if timer > output_polling_timeout | ||
| update_with_failure(job, 'Timed out waiting for alt-text') | ||
| FileUtils.rm_f(tmp_path) | ||
| return true | ||
| end | ||
| end |
There was a problem hiding this comment.
The polling process here can be removed. AltText::Client#process_image immediately returns the generated alt-text once done. It isn't checking for a file like the PDF remediation process.
app/jobs/image_alt_text_job.rb
Outdated
| # File.delete(tmp_path) if File.exist?(tmp_path) | ||
| include AppJobModule | ||
|
|
||
| def perform(job_uuid, tmp_path, output_polling_timeout: OUTPUT_POLLING_TIMEOUT) |
There was a problem hiding this comment.
Also, the output_polling_timeout argument can be removed.
app/jobs/image_alt_text_job.rb
Outdated
| finished_at: Time.zone.now, | ||
| alt_text: alt_text | ||
| ) | ||
| FileUtils.rm_f(tmp_path) |
There was a problem hiding this comment.
We should put the file delete in an ensure block after the rescue so it always happens, even when there's an error.
ajkiessl
reviewed
Oct 21, 2025
app/jobs/image_alt_text_job.rb
Outdated
| job = Job.find_by!(uuid: job_uuid) | ||
| alt_text = client.process_image( | ||
| tmp_path, | ||
| prompt: File.read('prompt.txt'), |
There was a problem hiding this comment.
This works, but it might be safer to include the full path like this:
File.read(Rails.root.join("prompt.txt"))
So it knows where that file is regardless of where a rails process is ran.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #159
This provides the logic for the ImageAltText Job, and uses our own AltText gem to create alt text for whatever we upload. Though the alt text is added to the ImageJob model, live updates are not implemented until ticket 161.