Skip to content

fix: transport module error log level #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: transport module error log level #256

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d489f7c
categorising network issues details as warning logs
Jun 26, 2025
d68882a
take-1: alternate serializer
Jun 26, 2025
4979843
fix: System.Text.Json version for UWP
Jun 27, 2025
840de59
replaced PeterO.Cbor with System.Formats.Cbor
Jun 27, 2025
3f757c4
revert to d489f7c
Jun 27, 2025
d61ae6a
removed ParseToken() implementation
Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Api/PubnubApi/ClientNetworkStatus.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ internal static bool CheckInternetStatus<T>(bool systemActive, PNOperationType
} catch (AggregateException ae) {
foreach (var ie in ae.InnerExceptions)
{
PubnubConfiguation?.Logger?.Error($"AggregateException CheckInternetStatus : {ie.GetType().Name} {ie.Message}");
PubnubConfiguation?.Logger?.Warn($"AggregateException CheckInternetStatus : {ie.GetType().Name} {ie.Message}");
}
} catch (Exception ex)
{
PubnubConfiguation?.Logger?.Error($"CheckInternetStatus Exception: {ex.Message}");
PubnubConfiguation?.Logger?.Warn($"CheckInternetStatus Exception: {ex.Message}");
}

return networkStatus;
Expand Down
2 changes: 1 addition & 1 deletion src/Api/PubnubApi/EventEngine/Common/EventEmitter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public void EmitEvent<T>(object e)
catch (Exception ex)
{
decryptMessage = "**DECRYPT ERROR**";
configuration?.Logger?.Error("Failed to decrypt message on channel {currentMessageChannel} due to exception={ex}.\n Message might be not encrypted");
configuration?.Logger?.Warn("Failed to decrypt message on channel {currentMessageChannel} due to exception={ex}.\n Message might be not encrypted");
}

object decodeMessage = jsonLibrary.DeserializeToObject((decryptMessage == "**DECRYPT ERROR**") ? jsonLibrary.SerializeToJsonString(payload) : decryptMessage);
Expand Down
10 changes: 5 additions & 5 deletions src/Api/PubnubApi/Transport/HttpClientService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public async Task<TransportResponse> GetRequest(TransportRequest transportReques
}
catch (Exception e)
{
logger?.Error(
logger?.Warn(
$"HttpClient Service: Exception for http call url {transportRequest.RequestUrl}, exception message: {e.Message}, stacktrace: {e.StackTrace}");
transportResponse = new TransportResponse()
{
Expand Down Expand Up @@ -149,7 +149,7 @@ public async Task<TransportResponse> PostRequest(TransportRequest transportReque
}
catch (Exception e)
{
logger?.Error(
logger?.Warn(
$"Exception for http call url {transportRequest.RequestUrl}, exception message: {e.Message}, stacktrace: {e.StackTrace}");
transportResponse = new TransportResponse()
{
Expand Down Expand Up @@ -228,7 +228,7 @@ public async Task<TransportResponse> PutRequest(TransportRequest transportReques
}
catch (Exception e)
{
logger?.Error(
logger?.Warn(
$"Exception for http call url {transportRequest.RequestUrl}, exception message: {e.Message}, stacktrace: {e.StackTrace}");
transportResponse = new TransportResponse()
{
Expand Down Expand Up @@ -291,7 +291,7 @@ public async Task<TransportResponse> DeleteRequest(TransportRequest transportReq
}
catch (Exception e)
{
logger?.Error(
logger?.Warn(
$"Exception for http call url {transportRequest.RequestUrl}, exception message: {e.Message}, stacktrace: {e.StackTrace}");
transportResponse = new TransportResponse()
{
Expand Down Expand Up @@ -371,7 +371,7 @@ public async Task<TransportResponse> PatchRequest(TransportRequest transportRequ
}
catch (Exception e)
{
logger?.Error(
logger?.Warn(
$"Exception for http call url {transportRequest.RequestUrl}, exception message: {e.Message}, stacktrace: {e.StackTrace}");
transportResponse = new TransportResponse()
{
Expand Down
Loading