when no repo, use synchronous upload for rpm - #1249
Merged
Merged
Conversation
Contributor
Author
|
/retest |
YasenT
marked this pull request as ready for review
October 16, 2025 14:34
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
ggainey
requested changes
Oct 17, 2025
ggainey
requested changes
Nov 10, 2025
ggainey
requested changes
Nov 12, 2025
ggainey
left a comment
Contributor
There was a problem hiding this comment.
This looks good and everything passes! Let's do a squash on these commits and resubmit, and then we can merge!
YasenT
force-pushed
the
rpm_synchronous_upload
branch
from
November 13, 2025 11:46
8bdef0f to
153be9a
Compare
ggainey
approved these changes
Nov 13, 2025
ggainey
left a comment
Contributor
There was a problem hiding this comment.
Squash looks clean, test ssay we havben't broken anything - lgtm :)
Backport to 0.36: 💚 backport PR created✅ Backport PR branch: Backported as #1286 🤖 @patchback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extending the rpm uploads to use synchronous endpoint