Skip to content

facter: change sys-filesystem to a runtime dep #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

facter: change sys-filesystem to a runtime dep #2783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions facter.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,23 +29,25 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
spec.require_paths = ['lib']

# While we require both ffi and sys-filesystem in parts of Facter, we specify
# them as development, not runtime, dependencies. Both gems either directly
# or indirectly contain native extensions. The intent behind excluding these
# gems from runtime dependencies is to allow users to be able to install
# Facter without a compiler.
# ffi 1.16.0 - 1.16.2 are broken on Windows
spec.add_development_dependency 'ffi', '>= 1.15.5', '< 1.17.0', '!= 1.16.0', '!= 1.16.1', '!= 1.16.2'
spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
spec.add_development_dependency 'rspec', '~> 3.0'
spec.add_development_dependency 'rubocop', '~> 1.28' # last version to support 2.5
spec.add_development_dependency 'rubocop-performance', '~> 1.5.2'
spec.add_development_dependency 'rubocop-rspec', '~> 2.10' # last version to support 2.5
spec.add_development_dependency 'simplecov', '~> 0.17.1'
spec.add_development_dependency 'sys-filesystem', '~> 1.4'
spec.add_development_dependency 'webmock', '~> 3.12'
spec.add_development_dependency 'yard', '~> 0.9'

# ffi 1.16.0 - 1.16.2 are broken on Windows
spec.add_runtime_dependency 'ffi', '>= 1.15.5', '< 1.17.0', '!= 1.16.0', '!= 1.16.1', '!= 1.16.2'
spec.add_runtime_dependency 'hocon', '~> 1.3'
# Without sys-filesystem the mountpoints fact returns no data and the
# partitions fact reports incorrect data, as it is missing the mount
# information for partitions. Though adding sys-filesystem as a runtime
# dependency requires gem install invocations to have a C compiler available,
# this requirement is preferred to producing a broken gem. Adding as a
# runtime dependency also ensures that tools such as gem2deb properly include
# sys-filesystem as a dependency.
spec.add_runtime_dependency 'sys-filesystem', '~> 1.4'
spec.add_runtime_dependency 'thor', ['>= 1.0.1', '< 1.3'] # Thor 1.3.0 drops support for Ruby 2.5
end
Loading