Skip to content

update regex to allow underscores in firewall name #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

update regex to allow underscores in firewall name #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
edb460d
update regex to allow underscores in firewall name
dlware Nov 2, 2023
8d75f8c
Merge branch 'main' into add_underscores
dlware Nov 14, 2023
90bbd92
Merge branch 'main' into add_underscores
dlware Dec 4, 2023
2c98aaa
Merge branch 'main' into add_underscores
dlware Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion REFERENCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1697,7 +1697,7 @@ The following parameters are available in the `firewall` type.

namevar

Data type: `Pattern[/(^\d+(?:[ \t-]\S+)+$)/]`
Data type: `Pattern[/(^\d+(?:[ \t-_]\S+)+$)/]`
_*this data type contains a regex that may not be accurately reflected in generated documentation_

The canonical name of the rule. This name is also used for ordering
Expand Down
2 changes: 1 addition & 1 deletion lib/puppet/type/firewall.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
DESC
},
name: {
type: 'Pattern[/(^\d+(?:[ \t-]\S+)+$)/]',
type: 'Pattern[/(^\d+(?:[ \t-_]\S+)+$)/]',
behaviour: :namevar,
desc: <<-DESC
The canonical name of the rule. This name is also used for ordering
Expand Down