(CAT-2345) Prepare module for Puppetcore / Drop Support for Puppet 7 #1265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david22swan
force-pushed
the
CAT-2345
branch
3 times, most recently
from
ee18230 to
14ee288
Compare
|
Waiting on fixes to litmusimages |
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the module for Puppetcore by removing support for Puppet 7 and updating dependencies to target Puppet 8+. The changes focus on updating test configurations and build tooling to align with newer Puppet standards.
- Removes Puppet 7 support by updating minimum version requirement from 7.0.0 to 8.0.0
- Updates test configurations to use Debian 12 instead of Debian 10 for primary testing
- Modernizes development dependencies and Ruby version targeting
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| metadata.json | Updates Puppet version requirement and PDK template references |
| spec/spec_helper_local.rb | Removes Debian 10 shared context and adds Debian 12 context |
| spec/unit/classes/firewall_spec.rb | Updates test contexts from Debian 10 to Debian 12 |
| spec/unit/classes/firewall_linux_debian_spec.rb | Updates all test contexts from Debian 10/11 to Debian 11/12 |
| spec/unit/puppet/provider/firewall/firewall_public_spec.rb | Fixes regex syntax in test expectation |
| Gemfile | Updates gem versions and adds Puppetcore authentication support |
| Rakefile | Adds PuppetLint configuration settings |
| .rubocop.yml | Updates target Ruby version from 2.6 to 3.1 |
| .rubocop_todo.yml | Removes resolved Rubocop offenses |
| .puppet-lint.rc | Adds multiple lint check configurations |
david22swan
changed the title
|
Closing and reopening to rekick tests. |
Debian 10 facts are no longer included within facterdb, as we do not test all fact versions I feel Debian 12 is a suitable alternative.
david22swan
force-pushed
the
CAT-2345
branch
4 times, most recently
from
e81a116 to
36a159a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR prepares the module for Puppetcore by removing support for Puppet 7 and updating dependencies to target Puppet 8+. The changes focus on updating test configurations and build tooling to align with newer Puppet standards.
Checklist
puppet apply)