- 
        Couldn't load subscription status. 
- Fork 1.1k
Add guidance about SDMs to User Guide #2565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            6 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      f9606dc
              
                initial additions
              
              
                kandersolar 241ba2c
              
                fix table
              
              
                kandersolar 2be74c2
              
                revisions
              
              
                kandersolar 8f529c8
              
                whatsnew
              
              
                kandersolar 4dd10da
              
                Apply suggestions from code review
              
              
                kandersolar d5b80a6
              
                Update docs/sphinx/source/user_guide/modeling_topics/singlediode.rst
              
              
                kandersolar File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of "Guaranteed convergence", I would caution here that lambertw-based solvers can suffer from numerical issues in some regimes. IIRC, this was a main issue that Ken Roberts tried to solve in https://arxiv.org/abs/1504.01964. (A second would be a method that converges faster than lambertw.) See also #1856. Speaking of which, would you be interested in any help getting the LogWright based solvers across the finish line @kandersolar? Review, testing, inter-comparisons, ...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the use of "explicit" here is subject to debate, as I wouldn't be surprised if there is an iterative solver hiding underneath scipy's implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fairly sure scipy uses Halley's method under the hood. The point about "explicit" is that the solution of the diode equation is explicit, not that calculation of its value doesn't require an iterative method. Maybe that distinction is unclear in the table headings.
Ken's paper is about avoiding numerical overflow at very large arguments, which can occur in the "v_from_i" calculation. pvlib handles those in a manner similar to Ken's, by solving for log(W(x)) rather than W(x).