-
Notifications
You must be signed in to change notification settings - Fork 72
Spanish translation documentation.po from lines 470-1180 #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR @aplozadab ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gracias @aplozadab ! I just have a few small comments.
|
||
#: ../../documentation/index.md:32 | ||
msgid "LICENSE files" | ||
msgstr "" | ||
msgstr "Archivos de LICENCIA" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here LICENSE is uppercase because that is the name of the file you should create. In general we don't translate those words. Maybe we should say something like "Archivo LICENSE" we could add after licencia in parenthesis after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the feedback. will fix.
About your comment on the level 3 headings, could you show/point me to an example (link or screenshot)? Thanks! |
Co-authored-by: Felipe Moreno <[email protected]>
Co-authored-by: Felipe Moreno <[email protected]>
Good catch on the level 3 titles! I cannot explain why they are not being translated. 😕 I will merge this PR since the problem is unrelated. I just checked and the current published Japanese translation has the same bug. We should create a separate issue about this so we can investigate and track the fix. Would you like to do that, so you can get credit for finding it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks @aplozadab !
I used a combination of manual translation and ai translation. then I manually reviewed and edited each line. this is just lines 470 to 1180 that i manually reviewed and corrected.
built and tested locally.
noticed that markdown level 3 headings are not being translated by sphinx. maybe a conf.py tweak needed.