-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Free threaded support #12555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Free threaded support #12555
Conversation
I guess because I'm not using the |
Great
…On Thu, Mar 6, 2025 at 5:03 PM Nathan Goldbaum ***@***.***> wrote:
@ngoldbaum commented on this pull request.
________________________________
In src/rust/src/padding.rs:
> @@ -110,6 +110,62 @@ impl PKCS7PaddingContext {
}
}
+#[pyo3::pyclass]
I'll cherrypick the Rust ports and make them their own PRs and keep the free-threading-specific stuff in this PR.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
e0636ce
to
3028574
Compare
3028574
to
146a9a3
Compare
146a9a3
to
3419fed
Compare
8beff7d
to
ece9508
Compare
01f5670
to
62e1ee6
Compare
@alex it looks like all the wheel builds are successful except for win32 and armv7. See these actions runs on my fork: win32: https://github.com/ngoldbaum/cryptography/actions/runs/16601346439/job/46961605807?pr=2 Not sure what to do about these. Do you have any ideas? I also disabled some manylinux2014 builds due to the issue that should be fixed by python-cffi/cffi#184. I also wasn't able to run ppc64le on my fork so let's see if there are any issues there. Are you OK with me marking all the rust PyModules with |
IDK what's going on with the win32 one. The armv7 one seems to suggest the build is building an aarch64 wheel, which is obviously just wrong. And yes, going to gil_used=False is fine, we don't rely on it. |
it occurs to me that the |
Towards fixing #12489.
Adds free-threaded CI using a hacky workaround to avoid building against the version of cffi on PyPI.
xref #12590