-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Support for DataTree.to_netcdf to write to a file-like object or bytes #10571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+464
−162
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7ba5f85
Improve reading and writing of NetCDF files to/from bytes or file-lik…
mjwillson 7b2d8aa
Add a test for Dataset.to_netcdf(engine='h5netcdf') and fix a bug whe…
mjwillson 0176558
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c4e2b9a
Move close() fixes into scipy backends
shoyer 21b1618
Fix type annotations
shoyer d778fdf
Fix error from arViz
shoyer 6317631
better typing and different fixes
shoyer 8fe46c0
Fixes per review, also use memoryview for return value
shoyer 754737d
one more test
shoyer bf2c750
remove unnecessary use of BytesIO
shoyer 23d5147
remove inadvertent print()
shoyer 54427fe
Fix typing
shoyer ceef536
Merge branch 'main' into datatree_netcdf_bytes
shoyer 07a3708
Don't silently override engine in to_netcdf
shoyer 4ea9d06
Merge branch 'main' into datatree_netcdf_bytes
kmuehlbauer 53739ff
Use type alias instead of refining filename_or_obj type everywhere
shoyer 07bbe18
Fix grammar
shoyer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if the explicit mention of netCDF file here (and in the other
open_*
-functions is still valid in light of all the other engines which handle files of any provenience. A change to this might better be done in another PR. I just stumbled over this and wanted to keep log of this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a good consideration for updating later.