Skip to content

Adding threading lock for possible other instruments handled in thread #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding threading lock for possible other instruments handled in thread #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions minimalmodbus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
__version__ = "2.1.1"

import sys
import threading

if sys.version_info < (3, 8, 0):
raise ImportError(
Expand Down Expand Up @@ -122,6 +123,7 @@ def __init__(
mode: str = MODE_RTU,
close_port_after_each_call: bool = False,
debug: bool = False,
lock: threading.Lock = threading.Lock()
) -> None:
"""Initialize instrument and open corresponding serial port."""
self.address = slaveaddress
Expand All @@ -135,7 +137,7 @@ def __init__(

New in version 2.0: Support for broadcast
"""

self.lock = lock
self.mode = mode
"""Slave mode (str), can be :data:`minimalmodbus.MODE_RTU` or
:data:`minimalmodbus.MODE_ASCII`. Most often set by the constructor (see the
Expand Down Expand Up @@ -1350,7 +1352,8 @@ def _perform_command(self, functioncode: int, payload_to_slave: bytes) -> bytes:
)

# Communicate
response_bytes = self._communicate(request_bytes, number_of_bytes_to_read)
with self.lock:
response_bytes = self._communicate(request_bytes, number_of_bytes_to_read)

if number_of_bytes_to_read == 0:
return b""
Expand Down