Add support for enabling OpenRC service on a specific runlevel

docs/contributing.md

@@ -78,7 +78,7 @@ pytest -m end_to_end_docker
 
 ## Documentation
 
-Documentation changes should be made in the [pyinfra git repository](https://github.com/pyinfra-dev/pyinfa) - the repository `docs.pyinfra.com` should
+Documentation changes should be made in the [pyinfra git repository](https://github.com/pyinfra-dev/pyinfra) - the repository `docs.pyinfra.com` should
 not be changed, it contains build artifacts.
 
 ### Generate Documentation

pyinfra/operations/openrc.py

@@ -48,10 +48,16 @@ def service(
         openrc_enabled = host.get_fact(OpenrcEnabled, runlevel=runlevel)
         is_enabled = openrc_enabled.get(service, False)
 
-        if enabled and not is_enabled:
-            yield "rc-update add {0}".format(service)
-            openrc_enabled[service] = True
-
-        if not enabled and is_enabled:
-            yield "rc-update del {0}".format(service)
-            openrc_enabled[service] = False
+        if enabled is True:
+            if not is_enabled:
+                yield "rc-update add {0} {1}".format(service, runlevel)
+                openrc_enabled[service] = True
+            else:
+                host.noop("service {0} is enabled".format(service))
+
+        if enabled is False:
+            if is_enabled:
+                yield "rc-update del {0} {1}".format(service, runlevel)
+                openrc_enabled[service] = False
+            else:
+                host.noop("service {0} is disabled".format(service))

tests/operations/openrc.service/disable.json

@@ -16,6 +16,6 @@
         }
     },
     "commands": [
-        "rc-update del nginx"
+        "rc-update del nginx default"
     ]
 }

tests/operations/openrc.service/disable_noop.json

@@ -0,0 +1,20 @@
+{
+    "args": ["nginx"],
+    "kwargs": {
+        "enabled": false
+    },
+    "facts": {
+        "openrc.OpenrcStatus": {
+            "runlevel=default": {
+                "nginx": true
+            }
+        },
+        "openrc.OpenrcEnabled": {
+            "runlevel=default": {
+                "nginx": false
+            }
+        }
+    },
+    "commands": [],
+    "noop_description": "service nginx is disabled"
+}

tests/operations/openrc.service/disable_runlevel.json

@@ -0,0 +1,22 @@
+{
+    "args": ["nftables"],
+    "kwargs": {
+        "runlevel": "boot",
+        "enabled": false
+    },
+    "facts": {
+        "openrc.OpenrcStatus": {
+            "runlevel=boot": {
+                "nftables": true
+            }
+        },
+        "openrc.OpenrcEnabled": {
+            "runlevel=boot": {
+                "nftables": true
+            }
+        }
+    },
+    "commands": [
+        "rc-update del nftables boot"
+    ]
+}

tests/operations/openrc.service/enable.json

@@ -16,6 +16,6 @@
         }
     },
     "commands": [
-        "rc-update add nginx"
+        "rc-update add nginx default"
     ]
 }

tests/operations/openrc.service/enable_noop.json

@@ -0,0 +1,20 @@
+{
+    "args": ["nginx"],
+    "kwargs": {
+        "enabled": true
+    },
+    "facts": {
+        "openrc.OpenrcStatus": {
+            "runlevel=default": {
+                "nginx": true
+            }
+        },
+        "openrc.OpenrcEnabled": {
+            "runlevel=default": {
+                "nginx": true
+            }
+        }
+    },
+    "commands": [],
+    "noop_description": "service nginx is enabled"
+}

tests/operations/openrc.service/enable_runlevel.json

@@ -0,0 +1,22 @@
+{
+    "args": ["nftables"],
+    "kwargs": {
+        "runlevel": "boot",
+        "enabled": true
+    },
+    "facts": {
+        "openrc.OpenrcStatus": {
+            "runlevel=boot": {
+                "nftables": true
+            }
+        },
+        "openrc.OpenrcEnabled": {
+            "runlevel=boot": {
+                "nftables": false
+            }
+        }
+    },
+    "commands": [
+        "rc-update add nftables boot"
+    ]
+}