Skip to content

Conversation

yarikoptic
Copy link

More about shellcheck: https://www.shellcheck.net/

I personally introduced it to a good number of my and projects of others
already and so far only positive feedback.

CI workflow has 'permissions' set only to 'read' so also should be safe.

Individual commits might have more information.

On 3.x branch you would get now (shellcheckit is just a little helper I have to prep this PR etc)

❯ shellcheckit doit
pyinfra/connectors/util.py:#!/bin/sh
scripts/build-public-docs.sh:#!/bin/bash
scripts/dev-lint.sh:#!/usr/bin/env bash
scripts/dev-test-e2e.sh:#!/usr/bin/env bash
scripts/dev-test.sh:#!/usr/bin/env bash
scripts/release.sh:#!/bin/sh
scripts/spellcheck.sh:#!/usr/bin/env bash

In scripts/build-public-docs.sh line 29:
    env DOCS_VERSION=$BRANCH_NAME sphinx-build -a docs/ docs/public/en/$BRANCH_NAME/
                     ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                       ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    env DOCS_VERSION="$BRANCH_NAME" sphinx-build -a docs/ docs/public/en/"$BRANCH_NAME"/


In scripts/build-public-docs.sh line 33:
        env DOCS_VERSION=$BRANCH_NAME python scripts/generate_redirect_pages.py
                         ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
        env DOCS_VERSION="$BRANCH_NAME" python scripts/generate_redirect_pages.py


In scripts/dev-test.sh line 6:
pytest $@
       ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In scripts/release.sh line 3:
set -euo pipefail
         ^------^ SC3040 (warning): In POSIX sh, set option pipefail is undefined.


In scripts/release.sh line 5:
VERSION=`python setup.py --version`
        ^-------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean: 
VERSION=$(python setup.py --version)


In scripts/release.sh line 6:
MAJOR_BRANCH="`python setup.py --version | cut -d'.' -f1`.x"
              ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean: 
MAJOR_BRANCH="$(python setup.py --version | cut -d'.' -f1).x"

For more information:
  https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
  https://www.shellcheck.net/wiki/SC3040 -- In POSIX sh, set option pipefail ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "shellcheckit autopatch",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant