Sponsorship email logic #205
Conversation
Remove redundant line Co-authored-by: Kanishk Pachauri <[email protected]>
Co-authored-by: Kanishk Pachauri <[email protected]>
Co-authored-by: Kanishk Pachauri <[email protected]>
Co-authored-by: Kanishk Pachauri <[email protected]>
Co-authored-by: Kanishk Pachauri <[email protected]>
Co-authored-by: Mariatta <[email protected]>
Co-authored-by: Mariatta <[email protected]>
Co-authored-by: Mariatta <[email protected]>
Co-authored-by: Mariatta <[email protected]>
Co-authored-by: Mariatta <[email protected]>
Co-authored-by: Mariatta <[email protected]>
Co-authored-by: Mariatta <[email protected]>
👷 Deploy request for pyladiescon-portal-docs pending review.Visit the deploys page to approve it
|
|
|
||
| from .models import SponsorshipProfile | ||
|
|
||
| def _send_email(subject, recipient_list, *, html_template=None, text_template=None, context=None): |
There was a problem hiding this comment.
USe the _send_email that's already implemented in volunteer/models.py instead of creating a new one.
Perhaps refactor and move it out of the volunteer/models.py into a more common utils.py that is used by both sponsorships and volunteers
| if created: | ||
| # Email on submission | ||
| subject = f"{settings.ACCOUNT_EMAIL_SUBJECT_PREFIX} Sponsorship Application Received" | ||
| _send_email( |
There was a problem hiding this comment.
This is calling the internal _send_email() function. Should it call either the send_sponsorship_profile_email or send_sponsorship_status_emails?
|
Thanks for the PR. I think this includes changes from your first PR. You will need to update your branch, and pull the new changes from the I've left some comments for improvements. Additionally we need to have unit tests as well. |
|
Closing, duplicate of #213 |
2 participants
This PR adds backend logic to send automated email notifications when:
A new sponsorship profile is submitted.
A sponsorship application status is updated to "approved" via the Django admin.
Internal team members are notified of new sponsorship submissions and approvals.
Fix #12
Fix #17