-
Notifications
You must be signed in to change notification settings - Fork 10
Handle TbtData objects as input files #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit 31ea6e3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 95.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 85.7% (0.0% change). View more on Code Climate. |
I was thinking that we could possibly add an optional |
@fsoubelet @jgray-19 what do you think? about my last comment? |
The bypass would be in hole-in-one? |
If I read this PR correctly, the bypass is in hio. The issue is, that we use the filename also for the output file. Maels suggestion is to add another input parameter, that defines the filename. My suggestion is to add an extra field ( |
I think it's actually a decent idea in the TbtData object to pass the origin of the data. Most TFS tables do include an origin. So I like this as a small extension. I think it makes more sense the more output formats that can also include this. |
Now that XSuite exists, it's possible to run tracking simulations directly in python. Using harpy requires to create a TbtData object and write an SDDS.
This PR skips the SDDS writing step, as now
TbtData
objects can be loaded directly.Harpy's logic was to use the filename to determine the output, a new argument
tbt_name
is introduced for the user to choose the name of the output.