Prevent cache misses in do_import_module() #2206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If modname is None (default), it's okay to use the cache; there's no point in recreating the module ad nauseum. Closes pylint-dev#2041 Co-authored-by: Leandro T. C. Melo <[email protected]>
jacobtylerwalls
added
topic-performance
pylint-tested
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2206 +/- ##
==========================================
- Coverage 92.68% 92.68% -0.01%
==========================================
Files 94 94
Lines 10818 10820 +2
==========================================
+ Hits 10027 10028 +1
- Misses 791 792 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DanielNoord
reviewed
Jun 7, 2023
DanielNoord
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
If the
modnameargument is None, which it is a lot, since it's the default, it's okay to use the cache; there's no point in recreating the requested module every time.Closes #2041
See discussion on #2041 and duplicate issue #2124 for how this was sourced to #1747.
Not suggesting a backport or changelog; there's an argument that the astroid cache is public, but not a slam-dunk one, hence, this is really just a performance optimization I'd suggest just describing with all the 3.0 performance changes (which I suggest doing when the release is finalized).