[fix] Permit to display the output even in case of unicode errors #10489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
approved these changes
Aug 10, 2025
DanielNoord
approved these changes
Aug 10, 2025
Pierre-Sassoulas
force-pushed
the
backport-unicode-crash-fix
branch
from
f85e40a to
0d92db6
Compare
|
The fact that the functional tests class hide the real output is annoying. The actual output is: |
|
Need more work on the functional tests class (do you know what could be wrong ?) Or we can simply close. |
|
Letβs close! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Partial backport of #9732, closes #8736 on the maintenance branch.