Repository navigation
docs: explain conflict between C0209 and W1203 - #10680
Merged
Pierre-Sassoulas merged 4 commits intoMay 18, 2026
Merged
Pierre-Sassoulas merged 4 commits into
Pierre-Sassoulas merged 4 commits into
Conversation
Pierre-Sassoulas
added
Documentation 📗
Skip news 🔇
Pierre-Sassoulas
requested changes
Oct 19, 2025
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
Member
There was a problem hiding this comment.
Thank you for working on this. I think it would make more sense to add this in a details.rst in the page specific to C0209 / W1203
Pierre-Sassoulas
added
the
Waiting on author
Contributor
|
This PR needs take over because because it has been open 8 weeks with no activity. |
github-actions
Bot
added
the
Needs take over 🛎️
Pierre-Sassoulas
removed
Waiting on author
Pierre-Sassoulas
force-pushed
the
docs/fix-fstring-logging-conflict
branch
from
May 18, 2026 07:48
be8a956 to
6c6197a
Compare
Per review on pylint-dev#10680: rather than a new section in message_control.rst, the conflict belongs in the details.rst of each message. Also recommends lazy parameter passing as the canonical fix and links pylint-dev#5286. Refs pylint-dev#5286
Pierre-Sassoulas
force-pushed
the
docs/fix-fstring-logging-conflict
branch
from
May 18, 2026 07:54
6c6197a to
bafd79b
Compare
f-strings stay the default outside logging (per pylint-dev#5286 discussion); only inside logging calls is the parameter-passing form preferred. Mention the real motivation — skipping formatting when the record is filtered out, useful for arguments with an expensive ``__str__``/``__repr__``. Refs pylint-dev#5286
Pierre-Sassoulas
approved these changes
May 18, 2026
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
Member
There was a problem hiding this comment.
Thank you for documenting pylint :)
Pierre-Sassoulas
enabled auto-merge (squash)
May 18, 2026 08:51
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10680 +/- ##
==========================================
+ Coverage 96.21% 96.22% +0.01%
==========================================
Files 178 178
Lines 19693 19699 +6
==========================================
+ Hits 18948 18956 +8
+ Misses 745 743 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This adds documentation to clarify the conflict between the
C0209(consider-using-f-string) andW1203(logging-fstring-interpolation) messages.It explains why the conflict occurs and provides options to resolve it using message control in the pylintrc file.
Refs #5286