Updated Loupe Examining #259
Conversation
I also setup infra for entity scanning and fixed a number of bugs. So far the only issue I've encountered is scanning a block like a door, scanning the top part, will drop the item as the bottom breaks from the block update.
| is_pylon: "<red>Having built this, you can't think of anything interesting you might find out about it" | ||
| examined: "<green>As you examine the %item%, you get a sudden flash of insight" | ||
| is_other_plugin: "<red>You smug little knave, use vanilla items not plugin ones" | ||
| is_unbreakable: "<red>As the block is unbreakable, you can't examine it placed down" |
There was a problem hiding this comment.
Previously you could scan the block but without breaking it, can't we keep the behaviour as before? it would be cool if we added custom behaviour for such blocks like scanning a nether portal and an end portal
|
Just want to check, is this ready for review or is it intentional that it's still a draft? |
Its still a draft because I haven't added the entity examining or index yet, namely because we haven't really discussed either enough for me to start on an implementation |
tbh i am for replacing the loupe pdc entry from a material -> integer to a key -> integer, and also adding proper events for loupe so addons can add their custom research behaviour if they want to, as the loupe is pretty much a key item in pylon |
3 participants
Switches to use a raytrace for finding the targeted block/entity, feels better as a player as it now respects exactly what you're targeting.
Redoes the logic for starting & ending scanning to give more feedback to the player, add some polish, fix a few edge cases, and respect event results.
It also now allows you to use the loupe without examining something, so players can use it as a sort of magnifying glass or just have fun with it like you would a spy glass.
Current "Issues":
Todo: