Generify talisman code #351
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhmV-IR
changed the title
|
Todo: generify the code a bit more into a InventoryEffectItem for core |
LordIdra
requested changes
Oct 11, 2025
src/main/java/io/github/pylonmc/pylon/base/content/tools/base/Talisman.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/pylonmc/pylon/base/content/tools/HealthTalisman.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/pylonmc/pylon/base/content/tools/base/Talisman.java
Outdated
Show resolved
Hide resolved
|
Whats with all the extra commits |
Master must've gotten merged into this pr but not the base, not at pc rn so can't fix |
|
Ight, will review after that then |
|
Needs rebase or smth; diff is messed up |
done |
OhmV-IR
changed the title
Seggan
reviewed
Oct 29, 2025
| public abstract int getLevel(); | ||
|
|
||
| /** | ||
| * Get the generic key of the talisman, should be the same between all talismans of the same type, ie all health talisman levels have the same return value for this. |
There was a problem hiding this comment.
Suggested change
| * Get the generic key of the talisman, should be the same between all talismans of the same type, ie all health talisman levels have the same return value for this. | |
| * Get the generic key of the talisman, should be the same between all talismans of the same type, e.x. all health talisman levels have the same return value for this. |
Nit
Seggan
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #336