Item Builder Update #352
Merged
Item Builder Update #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marked as a draft on the chance I misunderstood the resolution we came to in #325 but reviews are welcome even now |
Seggan
approved these changes
Sep 30, 2025
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/fluid/PylonFluid.kt
Show resolved
Hide resolved
|
Have thought about this for a while and I don't like the fact that PylonItemStackBuilder is named as such but is not actually a builder (or even a class), but a set of utility methods that return builders. It feels quite misleading. It's also rather unclear at first glance why for example there is an |
|
Sure |
Base automatically changed from
use-vanilla-entities-in-pylon-entity-block-holder
to
master
October 4, 2025 16:37
|
doesn't compile, no review for you |
|
#blame-idra he broke master, you can still review it though?? (/lh) |
OhmV-IR
requested changes
Oct 5, 2025
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/util/ToolType.kt
Outdated
Show resolved
Hide resolved
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/item/builder/ItemStackBuilder.kt
Outdated
Show resolved
Hide resolved
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/item/builder/ItemStackBuilder.kt
Outdated
Show resolved
Hide resolved
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/item/builder/ItemStackBuilder.kt
Show resolved
Hide resolved
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/item/builder/ItemStackBuilder.kt
Outdated
Show resolved
Hide resolved
Seggan
approved these changes
Oct 5, 2025
LordIdra
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #325
Based on #341 as it modified the stack builder already and started on some of the changes I needed for this
Adds a PylonItemStackBuilder with new utils and moves the previous pylon item related ones from ItemStackBuilder to it.
Adds a number of new utility methods for both.
Gives ui items specific keys to be identifiable, also gives PylonFluid items a specific key and adds a method to get the fluid from the item stack representation