馃悰 fix(release): format generated changelog - #1170
Merged
Merged
Conversation
gaborbernat
force-pushed
the
harden-release-format
branch
3 times, most recently
from
August 27, 2026 22:36
8fb6987 to
34f2534
Compare
gaborbernat
changed the title
The 1.6.0 job ran the docstrfmt hook three times, was told Passed each time, and pushed a changelog pre-commit.ci rejects. The hook inspected no files and exited 0; every existing check keys off a hook failing, so a formatter doing no work passes them all. Require docstrfmt to report a non-zero file count, which --verbose exposes. The separate docstrfmt call goes away with it: it duplicated the hook's line width and could drift from it.
Nothing in tasks/ invokes docstrfmt now; the hook installs its own, so the pin and its keep-in-sync note have no reader.
gaborbernat
force-pushed
the
harden-release-format
branch
from
August 27, 2026 22:45
f74f5ba to
1dcf53c
Compare
gaborbernat
marked this pull request as draft
August 28, 2026 15:45
gaborbernat
changed the title
gaborbernat
marked this pull request as ready for review
August 28, 2026 18:29
henryiii
approved these changes
Aug 28, 2026
layday
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format the generated changelog with docstrfmt 2.2.1 before creating a release commit. v2.2.0 skipped
CHANGELOG.rstin GitHub'sbuild/buildcheckout, leaving the 1.6.0 changelog over 120 columns.Pin the release dependency and pre-commit hook to v2.2.1, with a package-specific cutoff timestamp so uv can install it before the seven-day window expires. Reformat the existing changelog to match docstrfmt's output.