Skip to content

Conversation

jeanas
Copy link
Contributor

@jeanas jeanas commented Dec 1, 2023

@willingc willingc added the diataxis: explanation Understanding oriented discussion (https://diataxis.fr/explanation/) label Dec 1, 2023
@jeanas
Copy link
Contributor Author

jeanas commented Dec 14, 2023

I've tried to address all comments. @webknjaz Could you take another look when you have a chance?

jeanas and others added 2 commits December 16, 2023 08:26
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Thank you for seeing this through!

@webknjaz webknjaz added this pull request to the merge queue Dec 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2023
@webknjaz webknjaz added this pull request to the merge queue Dec 17, 2023
Merged via the queue into pypa:main with commit 84b5491 Dec 17, 2023
@jeanas jeanas deleted the distribution-vs-import-package branch December 17, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diataxis: explanation Understanding oriented discussion (https://diataxis.fr/explanation/)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a discussion on distribution packages vs. import packages
6 participants