Merge overlapping --target install directories - #14268
Open
sronix wants to merge 1 commit into
Open
Conversation
sronix
marked this pull request as ready for review
August 21, 2026 02:33
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8799.
pip install --targetinstalls wheel contents into separate schemedirectories before moving them into the target. When package and
.datadirectories overlapped, target handling skipped or replaced one tree depending
on
--upgrade.Merge the scheme directories in a staging directory before applying existing
target replacement behavior. Duplicate files emit a warning, and the later
scheme entry takes precedence. File-directory conflicts fail before target
contents move.
Tests cover nested merges with and without
--upgrade, duplicate files, bothfile-directory conflict directions, and existing targets.
Tested with:
.venv/bin/pytest -q tests/functional/test_install.py -k target(15 passed).venv/bin/pre-commit run --all-filesPR Checklist:
Assisted-by: Claude and Codex