Repository navigation
Improve error message for mandatory attributes after defaults - #1639
Open
Topgearfanboy wants to merge 1 commit into
Open
Topgearfanboy wants to merge 1 commit into
Topgearfanboy wants to merge 1 commit into
Conversation
When a mandatory attribute appears after an attribute with a default value or factory, the error message now includes which attribute has the default, making it easier to identify the problem. Fixes python-attrs#437
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a mandatory attribute appears after an attribute with a default value or factory, the error message now includes which attribute has the default value. This makes it much easier to identify the problem and fix the attribute ordering.
Previously, the error message only mentioned the mandatory attribute that lacked a default:
Now it also shows which attribute has the default:
This addresses the issue raised in #437 where users struggled to understand which attributes were out of order, especially in complex inheritance scenarios or when using field transformers.
Test plan
tests/test_make.pyandtests/test_hooks.pyto match the new error message format