Rule based number formatting #1232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes from original Babel PR python-babel#660 python-babel#660
Recursion bugs removed by improved rule parsing and routing, recursion exception now handled Context improved by moving to dataclass Compute divisor fixed by adding precision context Plural tokens now parsed Typos and improved comments
…cales, fix linting errors
Open
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1232 +/- ##
==========================================
+ Coverage 91.93% 92.27% +0.33%
==========================================
Files 27 28 +1
Lines 4688 4972 +284
==========================================
+ Hits 4310 4588 +278
- Misses 378 384 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number spelling based on the pure Python implementation of the CLDR RBNF engine.
Currently only supports whole numbers (cardinal, ordinal, year) as fractional numbers are not well-defined and not universally implemented in CLDR.
Based on the original PR #660 with useful enhancements from @akx at #682 and additional work from the original author:
Extensive test cases are added, but should be considered smoke tests until a native speaker reviews them for each language.
Based on an earlier discussion: #114 and referenced in #179
Supersedes #682