Skip to content

gh-136681: make argsbuf static to speedup processing positional arguments with AC #136732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Jul 17, 2025

@skirpichev
Copy link
Contributor Author

benchmark: #136681 (comment)

@ZeroIntensity
Copy link
Member

Won't this break when called concurrently?

@skirpichev
Copy link
Contributor Author

Won't this break when called concurrently?

Yes, apparently it does :-( Probably, this can't be fixed easily.

Alternative approach should work: #136681 (comment). The _PyArg_UnpackKeywords() is implemented as a macro (which encodes fast-path) and a function. So, the if condition should keep negation of the fast-path condition in the macro (which can be removed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants