gh-136191: Unify commands to uppercase for wider support #136733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decision to unify commands in uppercase comes from adherence to the industry standard and RFC 5321. It was posted in the python discussions here: https://discuss.python.org/t/unify-all-smtplib-commands-to-be-uppercase/97482
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
aisk
reviewed
Jul 18, 2025
Comment on lines
+40
to
+41
| # Upper case commands for wider support as enumerated in section 2.4 of RFC 5321 | ||
| # by Steve Jacob <[email protected]> |
There was a problem hiding this comment.
There are some change logs in a module's source code, but usually we don't update them nowadays. Instead, we mention them in the news entry (where the PR author's name can also be credited).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decision to unify commands in uppercase comes from adherence to the industry standard and RFC 5321. It was posted in a python discussion and exists as issue 136191.