[3.14] gh-137179: Fix flaky test_history_survive_crash test (gh-137180) #137216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…137180) Kill the REPL subprocess once it prints the output from the command immediately before the `time.sleep()`. (cherry picked from commit 98d462c) Co-authored-by: Sam Gross <[email protected]>
miss-islington
requested review from
pablogsal,
lysnikolaou and
ambv
as code owners
colesbury
approved these changes
Jul 29, 2025
|
This just affects a test - it can wait until 3.14.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kill the REPL subprocess once it prints the output from the command
immediately before the
time.sleep().(cherry picked from commit 98d462c)
Co-authored-by: Sam Gross [email protected]
test_pyrepl.test_history_survive_crashflaky #137179