-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
gh-135676: Reword the f-string (and t-string) section #137469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
encukou
wants to merge
20
commits into
python:main
Choose a base branch
from
encukou:lex-analysis-fstrings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d4381aa
WIP: String literals
encukou 80ad85c
Use correct Pygments lexer for plain text
encukou e44fa66
WIP
encukou 86bf94b
More WIP
encukou faf05a1
Byte strings, raw strings; f-string stub
encukou 687fe58
Remove outdated comment
encukou 9f9d29c
Fix ReST errors
encukou 1e0c84a
TMP
encukou e7b57b5
Continue with f-strings
encukou 3733e0c
Merge in the main branch
encukou d593940
Work on the f-string semantics
encukou 0d8a917
Work on f-strings
encukou 366ecfc
Merge in the main branch
encukou 5fdb129
Details & start on the formal grammar
encukou e88843c
Improve text on whitespace in f-string debug expressions
encukou 394f835
Merge in the main branch
encukou f2db8f9
Comment on the funkiness of the t-string grammar
encukou 6468a97
Adjust t-string docs: move evaluation rules out, add a note on grammar
encukou 681112d
Apply suggestions from code review
encukou 9e1290f
Don't link TSTRING_START &c. since we don't define them
encukou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These example are duplicated, how about merging it all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are they duplicated?
I'm showing the
str()
andrepr()
output (without f-strings) to remind readers how these work withFraction
. Without them,f'{one_third!s} is {one_third!r}'
would make less sense.