gh-137829: Fix shelve tests for backend compatibility #137879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furkanonder
added
tests
picnixz
reviewed
Aug 18, 2025
Lib/test/test_shelve.py
Outdated
| os.mkdir(self.dirname) | ||
| self.addCleanup(os_helper.rmtree, self.dirname) | ||
|
|
||
| with self.assertRaises(dbm_sqlite3.error): | ||
| with self.assertRaises((TypeError, dbm.error)): |
There was a problem hiding this comment.
I missed this one in the first round of review, but could you move serializer and deserializer definitions out of the assertRaises boddy? TiA. If you don't want to shadow variables you can split the test into two (incomplete_serializer and incomplete_deserializer).
|
I also added a new test case for wrong types from custom serializers. For example when serializers return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.