-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
[docs] Fix grammar in ssl.SSLContect.sslsocket_class docstring #137935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
reviewed
Aug 19, 2025
gpshead
approved these changes
Aug 19, 2025
Thanks @PrinceNaroliya for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 19, 2025
…pythonGH-137935) Fix grammar in ssl.SSLContect.sslsocket_class docstring --------- (cherry picked from commit 379161d) Co-authored-by: PrinceNaroliya <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 19, 2025
…pythonGH-137935) Fix grammar in ssl.SSLContect.sslsocket_class docstring --------- (cherry picked from commit 379161d) Co-authored-by: PrinceNaroliya <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]>
GH-137950 is a backport of this pull request to the 3.14 branch. |
GH-137951 is a backport of this pull request to the 3.13 branch. |
picnixz
pushed a commit
that referenced
this pull request
Aug 19, 2025
…137935) (#137951) [docs] fix grammar in ssl.SSLContect.sslsocket_class docs (GH-137935) --------- (cherry picked from commit 379161d) Co-authored-by: PrinceNaroliya <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a grammatical issue in the documentation for
ssl.SSLContext.sslsocket_class
.Before
The return type of :meth:SSLContext.wrap_socket, defaults to
:class:SSLSocket. The attribute can be overridden on instance of class
in order to return a custom subclass of :class:SSLSocket.
After
The return type of :meth:SSLContext.wrap_socket, defaults to
:class:SSLSocket. The attribute can be assigned to on instances of
:class:SSLContext or overridden on subclasses of :class:SSLContext
in order to return a custom subclass of :class:SSLSocket.
Why
ssl
docs.Notes
Refs #103723
📚 Documentation preview 📚: https://cpython-previews--137935.org.readthedocs.build/