gh-88375, gh-111788: Fix parsing errors and normalization in robotparser #138502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
needs backport to 3.13
|
This PR fixes also #88375. |
serhiy-storchaka
force-pushed
the
robotparser-percent-encoding
branch
from
82bfaed to
9c026fa
Compare
…obotparser * Distinguish the query separator from a percent-encoded ?. * Fix support of non-UTF-8 robots.txt files. * Don't fail trying to parse weird paths.
serhiy-storchaka
force-pushed
the
robotparser-percent-encoding
branch
from
9c026fa to
b43f987
Compare
|
Also, this PR removes tests that does nothing. |
serhiy-storchaka
changed the title
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 5, 2025
… in robotparser (pythonGH-138502) * Don't fail trying to parse weird patterns. * Don't fail trying to decode non-UTF-8 "robots.txt" files. * No longer ignore trailing "?" in patterns and URLs. * Distinguish raw special characters "?", "=" and "&" from the percent-encoded ones. * Remove tests that do nothing. (cherry picked from commit cb7ef18) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 5, 2025
… in robotparser (pythonGH-138502) * Don't fail trying to parse weird patterns. * Don't fail trying to decode non-UTF-8 "robots.txt" files. * No longer ignore trailing "?" in patterns and URLs. * Distinguish raw special characters "?", "=" and "&" from the percent-encoded ones. * Remove tests that do nothing. (cherry picked from commit cb7ef18) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-138548 is a backport of this pull request to the 3.14 branch. |
|
GH-138549 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
changed the title
serhiy-storchaka
added a commit
that referenced
this pull request
Sep 5, 2025
…obotparser (GH-138502) (GH-138549) * Don't fail trying to parse weird patterns. * Don't fail trying to decode non-UTF-8 "robots.txt" files. * No longer ignore trailing "?" in patterns and URLs. * Distinguish raw special characters "?", "=" and "&" from the percent-encoded ones. * Remove tests that do nothing. (cherry picked from commit cb7ef18) Co-authored-by: Serhiy Storchaka <[email protected]>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
… in robotparser (pythonGH-138502) * Don't fail trying to parse weird patterns. * Don't fail trying to decode non-UTF-8 "robots.txt" files. * No longer ignore trailing "?" in patterns and URLs. * Distinguish raw special characters "?", "=" and "&" from the percent-encoded ones. * Remove tests that do nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.