gh-139821: Make tarfile.open correctly forward keyword arguments for zstd in stream mode.
#139822
+25
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beavailable
changed the title
tarfile.open correctly forward keyword arguments for zstd in stream mode.
emmatyping
reviewed
Oct 10, 2025
Lib/tarfile.py
Outdated
Comment on lines
340
to
341
| def __init__(self, name, mode, comptype, fileobj, bufsize, | ||
| compresslevel, preset): | ||
| compresslevel, preset, level, options, zstd_dict): |
There was a problem hiding this comment.
I think it would be cleaner at this point to take **kwargs in _Stream and pop items per-(de)compressor. Having stream take every possible argument doesn't seem like a great idea for readability purposes since many of the arguments will be unused. I believe because this was up in the air and also how to treat compressLevel vs level, we intentionally didn't include this in 3.14 before the beta cutoff.
There was a problem hiding this comment.
Oh, I see. Thanks for the explanation.
I'll rewrite it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tarfile.open()does not forward keyword arguments to the underlying_Streamobject for zstd in stream mode #139821📚 Documentation preview 📚: https://cpython-previews--139822.org.readthedocs.build/