Fix "lazy from (...) import (...)" tests#145213
Merged
FFY00 merged 1 commit intopython:mainfrom Feb 25, 2026
Merged
Conversation
Signed-off-by: Filipe Laíns <lains@riseup.net>
pablogsal
approved these changes
Feb 25, 2026
Member
|
Thanks @FFY00 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like
test_global_filter_fromandtest_global_filter_from_trueare importing the non-"from" version of the test data files, effectively skipping the tests for the "from" versions.The data files seem to be written for an outdated version of the implementation, and contain a typo in the lazy import statement. Since they were not actually being tested, they went unnoticed and were never fixed and updated.