Skip to content

Do not show protocol compatibility note against unpacked sequence or mapping #19358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged

Do not show protocol compatibility note against unpacked sequence or mapping #19358

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9b1295
Do not show protocol compat notice for unpacking
sterliakov Jun 29, 2025
05cf2e5
Add explicit types to guard against join-vs-union changes
sterliakov Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions mypy/checkexpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2684,9 +2684,12 @@ def check_arg(
context=context,
outer_context=outer_context,
)
self.msg.incompatible_argument_note(
original_caller_type, callee_type, context, parent_error=error
)
if not caller_kind.is_star():
# For *args and **kwargs this note would be incorrect - we're comparing
# iterable/mapping type with union of relevant arg types.
self.msg.incompatible_argument_note(
original_caller_type, callee_type, context, parent_error=error
)
if not self.msg.prefer_simple_messages():
self.chk.check_possible_missing_await(
caller_type, callee_type, context, error.code
Expand Down
14 changes: 14 additions & 0 deletions test-data/unit/check-functions.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3694,3 +3694,17 @@ def defer() -> int: ...
[out]
main: note: In function "a":
main:6: error: Unsupported operand types for + ("int" and "str")

[case testNoExtraNoteForUnpacking]
from typing import Protocol

class P(Protocol):
arg: int
# Something that list and dict also have
def __contains__(self, item: object) -> bool: ...

def foo(x: P, y: P) -> None: ...

foo(*[0, '']) # E: Argument 1 to "foo" has incompatible type "*list[object]"; expected "P"
foo(**{'x': 0, 'y': ''}) # E: Argument 1 to "foo" has incompatible type "**dict[str, object]"; expected "P"
[builtins fixtures/dict.pyi]
Loading