[mypyc] feat: exact_dict_rprimitive #19677
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobTheBuidler
commented
Aug 18, 2025
| @@ -196,7 +196,10 @@ def can_coerce_to(src: RType, dest: RType) -> bool: | |||
| if isinstance(src, RPrimitive): | |||
| # If either src or dest is a disjoint type, then they must both be. | |||
| if src.name in disjoint_types and dest.name in disjoint_types: | |||
| return src.name == dest.name | |||
| return src.name == dest.name or ( | |||
There was a problem hiding this comment.
there must be a better way to do this
|
@JukkaL is there anything blocking us from merging this one? I'll need to rebase the larger PR on master once we do, and then I can break that out into a few smaller PRs implementing the various features |
for more information, see https://pre-commit.ci
BobTheBuidler
force-pushed
the
patch-6
branch
from
551c2b8 to
328a11d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the exact_dict_rprimitive without doing anything with it yet.
Actual functionality will be introduced in a later PR.
This is ready for review.