Sync variance of typing classes in fixtures with typeshed #19778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sterliakov
force-pushed
the
chore/st-sync-fixture-variance
branch
from
90a99ff to
bb10017
Compare
sterliakov
commented
Sep 1, 2025
| @@ -18,8 +18,8 @@ class Iterable(Generic[T_co]): pass | |||
| class Iterator(Iterable[T_co]): pass | |||
| class Sequence(Iterable[T_co]): pass | |||
| class Mapping(Iterable[KT], Generic[KT, T_co]): | |||
| def keys(self) -> Iterable[T]: pass # Approximate return type | |||
There was a problem hiding this comment.
And this was weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally discovered in #19777. Our test fixtures use definitions that are very far from their real counterparts, but at least generics should match if possible. Let's see if it kills more than one testcase (expected from #19777).