[python-dateutil] dateutil.parser.parse(fuzzy_with_tokens=True) returns a tuple#15474
Open
ellieayla wants to merge 3 commits intopython:mainfrom
Open
[python-dateutil] dateutil.parser.parse(fuzzy_with_tokens=True) returns a tuple#15474ellieayla wants to merge 3 commits intopython:mainfrom
ellieayla wants to merge 3 commits intopython:mainfrom
Conversation
…ns a tuple @overload the parse function at module and class level, separate return type for fuzzy_with_tokens: Literal[True] and Literal[False]. Note, not entirely sure this syntax is perfect. mypy is happy locally, but that doesn't check against the upstream library behaviour. Could use a second pair of eyes. Closes issue python#15473 ref: https://github.com/dateutil/dateutil/blob/e081f6725fbb49cae6eedab7010f517e8490859b/src/dateutil/parser/_parser.py#L702 https://github.com/dateutil/dateutil/blob/e081f6725fbb49cae6eedab7010f517e8490859b/src/dateutil/parser/_parser.py#L871
This comment has been minimized.
This comment has been minimized.
Contributor
Author
The untyped definiton in
|
donbarbos
suggested changes
Feb 28, 2026
Contributor
donbarbos
left a comment
There was a problem hiding this comment.
Thank you! Only one comment
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@overload the parse function at module and class level, separate return type for fuzzy_with_tokens: Literal[True] and Literal[False].
Note, not entirely sure this syntax is perfect. mypy is happy locally, but that doesn't check against the upstream library behaviour. Could use a second pair of eyes.
Closes issue #15473
ref:
https://github.com/dateutil/dateutil/blob/e081f6725fbb49cae6eedab7010f517e8490859b/src/dateutil/parser/_parser.py#L702
https://github.com/dateutil/dateutil/blob/e081f6725fbb49cae6eedab7010f517e8490859b/src/dateutil/parser/_parser.py#L871