refactor input handling #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that the handler was not really in a good shape but I am not sure these changes make it simpler to be honest. |
|
Yap I am open to chat. Will message you there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I tried implementing my feature in impala, but I had a hard time navigating input handling. I noticed that most of the branching logic depends on the
Mode,KeyEventandFocusedBlock, so I refactored input handling to use a match on the tuple containing these. As a result I could get rid of many tabs & roughly 100 loc. I understand that this solution is far from perfect, but I believe that it makes navigating the code much easier. I also did not test every feature meticulously (yet) so please don't merge this pr yet. Let me know what you think, and if you have some improvements in mind.