[monarch] hyperactor: make sure that mock MAST jobs are unique #756
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, we cannot guarantee that the various world/proc names are unique. This was not a problem before D79478197 because each mesh was private -- the underlying agents were not wired together. However, since the mock MAST allocator uses the LocalAllocator to allocate host-local procs, they are now all wired together, and messages, and subsequently, we have overlapping routing entries. Differential Revision: [D79596215](https://our.internmc.facebook.com/intern/diff/D79596215/) [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Aug 4, 2025
Without this, we cannot guarantee that the various world/proc names are unique. This was not a problem before D79478197 because each mesh was private -- the underlying agents were not wired together. However, since the mock MAST allocator uses the LocalAllocator to allocate host-local procs, they are now all wired together, and messages, and subsequently, we have overlapping routing entries. Differential Revision: [D79596215](https://our.internmc.facebook.com/intern/diff/D79596215/) ghstack-source-id: 300660703 Pull Request resolved: #756
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79596215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Without this, we cannot guarantee that the various world/proc names are unique.
This was not a problem before D79478197 because each mesh was private -- the underlying agents were not wired together.
However, since the mock MAST allocator uses the LocalAllocator to allocate host-local procs, they are now all wired together, and messages, and subsequently, we have overlapping routing entries.
Differential Revision: D79596215