flush logs in the end no matter what #761
Open
+284
−420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79620358 |
|
This pull request was exported from Phabricator. Differential Revision: D79620358 |
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Aug 5, 2025
Summary: Pull Request resolved: pytorch-labs#761 make sure we are able to flush whatever remaining when program ends. However, we could still miss logs as log through channel is not always guaranteed to be streamed back when a program ends. Differential Revision: D79620358
highker
force-pushed
the
export-D79620358
branch
from
811704b to
0d61452
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79620358 |
highker
force-pushed
the
export-D79620358
branch
from
0d61452 to
aaa3129
Compare
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Aug 5, 2025
Summary: Pull Request resolved: pytorch-labs#761 make sure we are able to flush whatever remaining when program ends. However, we could still miss logs as log through channel is not always guaranteed to be streamed back when a program ends. Differential Revision: D79620358
Summary: instead of just dedup intergers, we switch to use edit distance to dedup arbitrary log lines. Differential Revision: D79492339
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Aug 5, 2025
Summary: make sure we are able to flush whatever remaining when program ends. However, we could still miss logs as log through channel is not always guaranteed to be streamed back when a program ends. Differential Revision: D79620358
highker
force-pushed
the
export-D79620358
branch
2 times, most recently
from
4cb03a5 to
8390893
Compare
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Aug 5, 2025
Summary: make sure we are able to flush whatever remaining when program ends. However, we could still miss logs as log through channel is not always guaranteed to be streamed back when a program ends. Differential Revision: D79620358
|
This pull request was exported from Phabricator. Differential Revision: D79620358 |
highker
force-pushed
the
export-D79620358
branch
from
8390893 to
3c34190
Compare
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Aug 5, 2025
Summary: Pull Request resolved: pytorch-labs#761 make sure we are able to flush whatever remaining when program ends. However, we could still miss logs as log through channel is not always guaranteed to be streamed back when a program ends. Differential Revision: D79620358
Summary: Pull Request resolved: pytorch-labs#761 make sure we are able to flush whatever remaining when program ends. However, we could still miss logs as log through channel is not always guaranteed to be streamed back when a program ends. Differential Revision: D79620358
|
This pull request was exported from Phabricator. Differential Revision: D79620358 |
highker
force-pushed
the
export-D79620358
branch
from
3c34190 to
3881a19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
make sure we are able to flush whatever remaining when program ends.
However, we could still miss logs as log through channel is not always
guaranteed to be streamed back when a program ends.
Differential Revision: D79620358