Extract the res backend to a separate class and export to python side #4714
+755
−443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D79192671 |
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 15, 2025
…pytorch#4714) Summary: X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
chouxi
force-pushed
the
export-D79192671
branch
from
3bb003e to
c053002
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 15, 2025
…pytorch#4714) Summary: X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
chouxi
force-pushed
the
export-D79192671
branch
from
c053002 to
7cd8370
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79192671 |
chouxi
force-pushed
the
export-D79192671
branch
from
7cd8370 to
f02bc4c
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 15, 2025
…pytorch#4714) Summary: Pull Request resolved: pytorch#4714 X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
|
This pull request was exported from Phabricator. Differential Revision: D79192671 |
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 16, 2025
…pytorch#4714) Summary: Pull Request resolved: pytorch#4714 X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
chouxi
force-pushed
the
export-D79192671
branch
2 times, most recently
from
b94f1a2 to
f43015e
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 18, 2025
…pytorch#4714) Summary: X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
|
This pull request was exported from Phabricator. Differential Revision: D79192671 |
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 18, 2025
…pytorch#4714) Summary: X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
chouxi
force-pushed
the
export-D79192671
branch
from
f43015e to
2a8bdb3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79192671 |
chouxi
force-pushed
the
export-D79192671
branch
from
2a8bdb3 to
3dfefd0
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 18, 2025
…pytorch#4714) Summary: X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 18, 2025
…pytorch#4714) Summary: X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
chouxi
force-pushed
the
export-D79192671
branch
from
3dfefd0 to
4338c64
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79192671 |
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 18, 2025
…pytorch#4714) Summary: X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
chouxi
force-pushed
the
export-D79192671
branch
from
4338c64 to
e2596b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79192671 |
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 18, 2025
…pytorch#4714) Summary: Pull Request resolved: pytorch#4714 X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
chouxi
force-pushed
the
export-D79192671
branch
from
e2596b5 to
6de370b
Compare
…pytorch#4714) Summary: Pull Request resolved: pytorch#4714 X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
|
This pull request was exported from Phabricator. Differential Revision: D79192671 |
chouxi
force-pushed
the
export-D79192671
branch
from
6de370b to
2396172
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 19, 2025
…pytorch#4714) Summary: X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 19, 2025
…pytorch#4714) Summary: X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 19, 2025
…pytorch#4714) Summary: X-link: facebookresearch/FBGEMM#1738 We're extending the raw embedding streaming to tables with UVM_CACHING. Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by [SplitTableBatchedEmbeddingBagsCodegen](https://www.internalfb.com/code/fbsource/fbcode/deeplearning/fbgemm/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py?lines=1349) that supports the UVM_CACHING tables. Differential Revision: D79192671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1738
We're extending the raw embedding streaming to tables with UVM_CACHING.
Extract the backend out to a standalone class under deeplearning/fbgemm/fbgemm_gpu/src/split_embeddings_cache folder, so the logic could be reused by SplitTableBatchedEmbeddingBagsCodegen that supports the UVM_CACHING tables.
Differential Revision: D79192671