Skip to content

Enable fp32 tests for Windows #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Aug 18, 2025

src/fp32/FbgemmFP32.cc could work on Windows by commenting out ASM code.

@meta-cla meta-cla bot added the cla signed label Aug 18, 2025
Copy link

netlify bot commented Aug 18, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 51c8771
🔍 Latest deploy log https://app.netlify.com/projects/pytorch-fbgemm-docs/deploys/68a56970fd76130008617bdb
😎 Deploy Preview https://deploy-preview-4722--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cyyever cyyever force-pushed the enable_fp32_win branch 3 times, most recently from b193d3f to 7e835e8 Compare August 18, 2025 01:14
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D80432703.

@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D80432703.

@q10
Copy link
Contributor

q10 commented Aug 18, 2025

@cyyever windows builds appear to be failing still :(

@cyyever cyyever marked this pull request as draft August 19, 2025 01:34
@cyyever cyyever force-pushed the enable_fp32_win branch 2 times, most recently from 438d9ed to ffe18e1 Compare August 20, 2025 06:20
Signed-off-by: cyy <[email protected]>
@cyyever cyyever marked this pull request as ready for review August 20, 2025 06:21
@cyyever cyyever marked this pull request as draft August 20, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants